Skip to content

Conversation

@dabrt
Copy link
Contributor

@dabrt dabrt commented Jul 23, 2025

Question Answer
JIRA Ticket N/A)
Versions 5.0
Edition all

Add information about ValueObject replacement

Checklist

  • Text renders correctly
  • Text has been checked with vale

@dabrt dabrt requested a review from Steveb-p July 23, 2025 15:14
@github-actions
Copy link

Preview of modified files

Preview of modified Markdown:

Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I suggest to convert the filepaths to FQCN (class names with the full namespace)

Copy link
Contributor

@adriendupuis adriendupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good information.

It's already good.
It can be improved now, or it could be merged as-is and improved in a latter second pass.

@dabrt dabrt requested a review from adriendupuis July 24, 2025 08:18
@dabrt dabrt merged commit 64218cf into 5.0 Jul 24, 2025
7 of 8 checks passed
@dabrt dabrt deleted the ValueObject-replacement branch July 24, 2025 08:33
dabrt added a commit that referenced this pull request Jul 24, 2025
* Add information about ValueObject replacement

---------

Co-authored-by: Marek Nocoń <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants